Re: [patch] Infinite loop in zip_fread

[Pierre Joye <pierre.php%gmail.com@localhost>]

On Tue, Feb 9, 2010 at 8:44 PM, Dieter Baron 
<dillo%danbala.tuwien.ac.at@localhost> wrote:
> On Feb 9, 2010, at 19:59, Alexander Galanin wrote:
>
>> On Tue, 9 Feb 2010 16:23:06 +0100
>> Dieter Baron <dillo%danbala.tuwien.ac.at@localhost> wrote:
>>
>>> On Feb 5, 2010, at 14:38, Alexander Galanin wrote:
>>>> On Thu, 4 Feb 2010 09:31:09 +0300
>>>> Alexander Galanin <al%galanin.nnov.ru@localhost> wrote:
>>>>
>>>>> Hello!
>>>>>
>>>>> I found that zip_fread enters infinite loop while reading file with bad
>>>>> CRC. You can reproduce the problem using attached test.
>>>
>>>  The attached zip archive contains only an empty directory, so I cannot 
>>> reproduce the bug.
>>
>> Oops, sorry. Correct archive is attached to this letter.
>
> Okay, I can reproduce the error with libzip 0.9.3 (it works fine with HEAD 
> from mercurial).
> I'll look into it.

Looks like the issue I reported some times ago. The new implementation
in HEAD has the checks in place, while 0.9.xdoes not.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org