NiH: libzip: libzip-discuss: Re: patch to fix leak and binary mode on windows

libzip: libzip-discuss: Re: patch to fix leak and binary mode on windows

Thread

Re: patch to fix leak and binary mode on windows, (continued)
- Re: patch to fix leak and binary mode on windows, Pierre Joye (2010/02/09 11:27:31)
- Re: patch to fix leak and binary mode on windows, Thomas Klausner (2010/02/09 13:22:49)
  - Re: patch to fix leak and binary mode on windows, Pierre Joye (2010/02/09 13:47:10)
    - Re: patch to fix leak and binary mode on windows, Thomas Klausner (2010/02/09 14:07:49)
- Re: patch to fix leak and binary mode on windows, Thomas Klausner (2010/02/09 13:59:19)

Message

From: Thomas Klausner <tk%giga.or.at@localhost>
To: Pierre Joye <pierre.php%gmail.com@localhost>
Subject: Re: patch to fix leak and binary mode on windows
Date: Tue, 9 Feb 2010 15:07:48 +0100

On Tue, Feb 09, 2010 at 02:47:09PM +0100, Pierre Joye wrote:
> It depends on the context default. The patch forces the mode to binary
> safe, making this code setting independent.

What contexts are there?
And why does it ignore fdopen's "b"?
Doesn't sound very reliable :)

Anyway, I've added the _setmode in #ifdef _WIN32 now. Thanks!
 Thomas

Made by MHonArc.