Re: patch to fix leak and binary mode on windows

[Pierre Joye <pierre.php%gmail.com@localhost>]

hi,

On Tue, Feb 9, 2010 at 2:22 PM, Thomas Klausner <tk%giga.or.at@localhost> wrote:
> On Mon, Feb 01, 2010 at 08:55:22PM +0100, Pierre Joye wrote:
>> - force binary mode on windows in zip close (you will have to add a
>> def for Windows, I use WINDOWS in this patch), it is required as the b
>> mode is ignored (or can be)
>
> What happens without the patch?

In the case the default mode is not binary safe, every operation will
be done in text mode. That means it will break binary entries (like
images for example).

> Is the default for Windows to create new files as text files?

It depends on the context default. The patch forces the mode to binary
safe, making this code setting independent.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org