Re: Windows patches

[Patrick Spendrin <ps_ml%gmx.de@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Pierre Joye schrieb:
> hi,
> 
> For the types, I would recomment to use the types with a known length
> (__int64 for example). A file like...
I think the question of long long vs. __int64 is merely a question of
style, so if someone says __int64 is better, then I am all for it.
> 
> _open does accept the permission argument:
Yes, that was not the point: The point is that the permission itself
doesn't map well to the Windows Permission system and should therefore
be avoided if possible. If one really wants to specify windows access
rights, then one should invest the time and use the winapi functions.
> 
> about 3,  it is a good thing to do, however did you notice bugs
> related to the directory separator?
Well, I couldn't think of them yet.
> 
> Btw, I'm not sure your patches pass with VC6. PHP bundles libzip
> (ext/zip/libzip) with a couple of minor tweaks for windows, some of
> the patches have been backported. You may take a look at it.
About VC6 I have no idea since I just don't have any copy of it. MinGW
should work though (at least when I checked it at least builds & I
haven't changed to much which is not ifdef'ed).
> 
> Cheers,
regards,
Patrick
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iEYEARECAAYFAksrbQ4ACgkQi49rfdk/G3YSJQCeN3PSa4q8aLcxSbv+fPGMB6sX
3R0AoILxaJsJuGFZQgGh4//kULdwkFn0
=G0Yo
-----END PGP SIGNATURE-----