Re: Windows patches

[Pierre Joye <pierre.php%gmail.com@localhost>]

hi,

For the types, I would recomment to use the types with a known length
(__int64 for example). A file like:

http://svn.php.net/viewvc/php/php-src/trunk/win32/php_stdint.h?revision=288149&view=markup

could be used.

_open does accept the permission argument:

http://msdn.microsoft.com/en-us/library/z0kc8e3z.aspx

about 3,  it is a good thing to do, however did you notice bugs
related to the directory separator?

Btw, I'm not sure your patches pass with VC6. PHP bundles libzip
(ext/zip/libzip) with a couple of minor tweaks for windows, some of
the patches have been backported. You may take a look at it.

Cheers,

On Fri, Dec 18, 2009 at 4:21 AM, Patrick Spendrin <ps_ml%gmx.de@localhost> 
wrote:
> I needed a bit longer to get familiar with mq, but here they are:
>
> 1) This fixes an issue with the check for zlib in the cmake buildsystem:
> since ZEXPORT is just a define on windows, it will not be found by the
> check - so we use a real version check instead. If wanted, I could
> modify the patch so that this configure check is hidden in a separate
> file. Also use ZLIB_LIBRARY as the library can also be called zlib eg.
>
> 2) Lots of Microsoft fixes:
> - suppressing stupid warnings
> - using special integer data types (please check whether I can really
> replace LLU with ULL on Linux!!!)
> - fixing exporting of functions from dll
> - some more fixes regarding mode_t, snprintf, strcasecmp and strdup
> - in zip* executables the function getopt is used; add a windows
> implementation as with MSVC there is none.
>
> 3) The path separator on windows is \ not / so replace all occurances
> with a define
>
> 4) On Windows at least, I would like to have the configuration header in
> the include directory.
>
> 5) The open function on windows can't really understand Unix
> permissions. This is more a problem of Windows not using the same
> user/group scheme as Unix, so it even builds without this patch, but it
> just doesn't work correctly (at least with msvc).
>
> I would really like to get these patches upstreams, so I don't have to
> patch KDE's version.
> I still have a patch for the regression tests, but I would like to hear
> your opinion first (see my other mail).
>
> regards,
> Patrick
>



-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org