Re: regression in 0.8/0.9 and ZIP_GPBF_DATA_DESCRIPTOR

[Pierre Joye <pierre.php%gmail.com@localhost>]

hi,

On Tue, May 19, 2009 at 9:26 AM, Dieter 
Baron<dillo%danbala.tuwien.ac.at@localhost> wrote:
> hi,
>
>> Any news on the  ZIP_GPBF_DATA_DESCRIPTOR front?
>
>  Sorry, no.  I have little time at the moment, and am in the middle
> of an API revision.  It is near the top of my TODO list, though.
>
>> The proposed fix
>> works well since months now on many users hosts.
>
>  The proposed fix creates broken zip files: it leaves the
> ZIP_GPBF_DATA_DESCRIPTOR flag bit set, but does not write a data
> descriptor.  It may work in practice (since most (all?) zip readers
> ignore the data descriptor anyway), but it's certainly not something
> I'm going to include in the mainline of libzip: Correctness is one of
> our main goals.
>
>  I'm still not certain whose fault the incompatibility is.  If libzip
> creates broken zip archives, we clearly need to fix it.  If oOO is
> broken, we'll have to find a solution that does not involve creating
> broken zip archives.

Someone came back with a patch for the php binding:

http://bugs.php.net/bug.php?id=48218

Can you take a look at it please? It seems to work for him but I did
not test it yet.

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org