Re: regression in 0.8/0.9 and ZIP_GPBF_DATA_DESCRIPTOR

[Dieter Baron <dillo%danbala.tuwien.ac.at@localhost>]

hi,

> Any news on the  ZIP_GPBF_DATA_DESCRIPTOR front?

  Sorry, no.  I have little time at the moment, and am in the middle
of an API revision.  It is near the top of my TODO list, though.

> The proposed fix
> works well since months now on many users hosts.

  The proposed fix creates broken zip files: it leaves the
ZIP_GPBF_DATA_DESCRIPTOR flag bit set, but does not write a data
descriptor.  It may work in practice (since most (all?) zip readers
ignore the data descriptor anyway), but it's certainly not something
I'm going to include in the mainline of libzip: Correctness is one of
our main goals.

  I'm still not certain whose fault the incompatibility is.  If libzip
creates broken zip archives, we clearly need to fix it.  If oOO is
broken, we'll have to find a solution that does not involve creating
broken zip archives.

  Again, sorry for the long delay.

                                        yours,
                                        dillo

> On Wed, Mar 25, 2009 at 6:20 PM, Pierre Joye <pierre.php%gmail.com@localhost> 
> wrote:
> 
> > On Wed, Mar 25, 2009 at 4:59 PM, Dieter Baron
> > <dillo%danbala.tuwien.ac.at@localhost> wrote:
> >
> >>  That is not true.  According to a simple test Thomas did, oOO can
> >> read a zip archive where general purpose flag bit three is *not* set,
> >> as created by unzipping the original archive and re-zipping it with
> >> zip.
> >
> > The test is about using an existing archive, replace an entry, close
> > the archive. I did not try to create an archive from scratch.
> >
> >>  Basically, that is what libzip is trying to do -- we do not stream
> >> the output zip archive, therefore we do not need to use a data
> >> descriptor or set general purpose flag bit 3.  It seems like libzip
> >> messes this up somehow; I'll have a look.
> >
> > Without the   if (de.bitflags & ZIP_GPBF_DATA_DESCRIPTOR) block code,
> > it works fine. It is also possible that some ODT readers are broken
> > (from a strict zip format point of view).
> 
> 
> 
> Cheers,
> -- 
> Pierre
> 
> http://blog.thepimp.net | http://www.libgd.org