Re: regression in 0.8/0.9 and ZIP_GPBF_DATA_DESCRIPTOR

[Pierre Joye <pierre.php%gmail.com@localhost>]

hi,

On Wed, Mar 25, 2009 at 4:59 PM, Dieter Baron
<dillo%danbala.tuwien.ac.at@localhost> wrote:

>  That is not true.  According to a simple test Thomas did, oOO can
> read a zip archive where general purpose flag bit three is *not* set,
> as created by unzipping the original archive and re-zipping it with
> zip.

The test is about using an existing archive, replace an entry, close
the archive. I did not try to create an archive from scratch.

>  Basically, that is what libzip is trying to do -- we do not stream
> the output zip archive, therefore we do not need to use a data
> descriptor or set general purpose flag bit 3.  It seems like libzip
> messes this up somehow; I'll have a look.

Without the   if (de.bitflags & ZIP_GPBF_DATA_DESCRIPTOR) block code,
it works fine. It is also possible that some ODT readers are broken
(from a strict zip format point of view).

>> I think it is critical enough (many zip users use it to work with odt
>> documents) to be solved. I wonder if it would make sense to fire a
>> minor release for 0.9.0 so an update can be done easily.
>
>  I'll see what I can do.

Thanks!

>> About the current code in the hg repository, there are a couple of
>> issues (integer types detections, portability on win like binary mode,
>> crash under certain condition) that have been either reintroduced or
>> never fixed.
>
>  We are currently in the process of refining the API to make it more
> portable (e.g. no more arguments of type size_t, ssize_t or off_t).
> When it's settled, we will publish a snapshot for public testing, so
> we can iron out these issues before the next release.
>
>  Please also feel free to report any issues before then.

I can fix the stdint-like definition on Windows, that will already
help :) Let me know when you are ready with the refining, I can then
provide a patch against hg's last version (is it called HEAD too? :).

>> Have you consider to use a bug tracker?
>
>  Yes, but we haven't found one that suited our needs (integrates well
> in our already slightly overloaded server environment, can be used via
> web and email, can be integrated into our web site.)

Tthere are many good trackers out there, choose one :). I can offer
hosting if your server is overloaded. It could drastically improve the
way other can contribute and follow a given issue.

>> and to publish
>> the commits via a mailing list?
>
>  Yes, we can probably do that with minimal effort.  I think
> redirecting replies to libzip-discuss and not archiving the source
> changes mailing list would make most sense.  Do you agree?  (However,
> be advised that the publically available hg copy is only updated every
> 6 hours, so you might have to wait a bit before acually accessing the
> changes.)

That will help already to follow more closely the devs :)

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org